Over all if you have brains its better that you trade this two beautiful market. I'm doing forex and stocks trading. And for me stocks is better. You can earn dividend. you can earn if the value of the stocks increases and you can do fundamental analysis much easy then forex since in stocks you are assisting a company. If for example apple release new Iphone and its has double its sales then Its a sure thing that the value of apple shares increases. But if theirs a failure in sales. then apple stocks value decreases.