there are many qualities of the good trader. a good trader must have to be a good analyser. to be a good traders daily work in foresx. i must have a good money management and must have the ability to control emotions. a good traders are a good learners and update their knowledge frequently.