Both type of trading is good but I prefer short term forex trading because I have a very less capital and for long term forex trading a large capital is needed. Fort me short term is best because I don't go for a big profit and close my trades on a small profit.