One should choose depending on there character, style of trading, capital available and the time available for trading.
For the people like me who has less time to do trading, long term trading is good and i am doing that, but sometimes when time permits i do scalping also.